Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736293

[PATCH v2 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device

From Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups linux.kernel
Subject [PATCH v2 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device
Date 2017-09-21 02:40 +0200
Message-ID <urXH5-1Ui-41@gated-at.bofh.it> (permalink)
References <urXH3-1Ui-3@gated-at.bofh.it> <urXH5-1Ui-43@gated-at.bofh.it> <urXH3-1Ui-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Prior to that, the min/max_freq of the devfreq device are always zero
before the user changes the min/max_freq through sysfs entries.
It might make the confusion for the min/max_freq.

This patch initializes the available min/max_freq by using the OPP
during adding the devfreq device.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/devfreq/devfreq.c | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a1c4ee818614..ae8717a6eee1 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -69,6 +69,34 @@ static struct devfreq *find_device_devfreq(struct device *dev)
 	return ERR_PTR(-ENODEV);
 }
 
+static unsigned long find_available_min_freq(struct devfreq *devfreq)
+{
+	struct dev_pm_opp *opp;
+	unsigned long min_freq = 0;
+
+	opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &min_freq);
+	if (IS_ERR(opp))
+		min_freq = 0;
+	else
+		dev_pm_opp_put(opp);
+
+	return min_freq;
+}
+
+static unsigned long find_available_max_freq(struct devfreq *devfreq)
+{
+	struct dev_pm_opp *opp;
+	unsigned long max_freq = ULONG_MAX;
+
+	opp = dev_pm_opp_find_freq_floor(devfreq->dev.parent, &max_freq);
+	if (IS_ERR(opp))
+		max_freq = 0;
+	else
+		dev_pm_opp_put(opp);
+
+	return max_freq;
+}
+
 /**
  * devfreq_get_freq_level() - Lookup freq_table for the frequency
  * @devfreq:	the devfreq instance
@@ -559,6 +587,21 @@ struct devfreq *devfreq_add_device(struct device *dev,
 		mutex_lock(&devfreq->lock);
 	}
 
+	/* Set the scaling available min_freq and max_freq */
+	devfreq->min_freq = find_available_min_freq(devfreq);
+	if (!devfreq->min_freq) {
+		mutex_unlock(&devfreq->lock);
+		err = -EINVAL;
+		goto err_dev;
+	}
+
+	devfreq->max_freq = find_available_max_freq(devfreq);
+	if (!devfreq->max_freq) {
+		mutex_unlock(&devfreq->lock);
+		err = -EINVAL;
+		goto err_dev;
+	}
+
 	dev_set_name(&devfreq->dev, "devfreq%d",
 				atomic_inc_return(&devfreq_no));
 	err = device_register(&devfreq->dev);
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the  frequency Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 02:40 +0200
  [PATCH v2 1/8] PM / devfreq: Set min/max_freq when adding the  devfreq device Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 02:40 +0200
  [PATCH v2 3/8] PM / devfreq: Show the available min/max frequency  through sysfs node Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 02:40 +0200
  [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 02:40 +0200
    Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling  device Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 07:00 +0200
  [PATCH v2 6/8] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-21 02:40 +0200
  [PATCH v2.1] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi <cw00.choi@samsung.com> - 2017-09-26 04:40 +0200

csiph-web