Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag

From	Jonathan Liu <net147@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag
Date	2017-09-21 00:10 +0200
Message-ID	<urVlT-yv-1@gated-at.bofh.it> (permalink)
References	<urpcm-4Vk-29@gated-at.bofh.it> <urrQS-6Dj-21@gated-at.bofh.it> <urypk-2ht-35@gated-at.bofh.it> <urQcy-5vV-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

On 21 September 2017 at 02:31, Thomas Garnier <thgarnie@google.com> wrote:
> On Tue, Sep 19, 2017 at 2:35 PM, Jonathan Liu <net147@gmail.com> wrote:
>>
>> Hi Thomas,
>>
>> The top of the C source file I am compiling has:
>> #include <linux/kernel.h>
>> #include <asm/uaccess.h>
>>
>> Tracing through the asm/uaccess.h include I see
>> asm/uaccess.h -> asm/domain.h -> asm/thread_info.h
>>
>> but set_thread_info is defined in linux/thread_info.h not
>> asm/thread_info.h (see
>> http://elixir.free-electrons.com/linux/v4.14-rc1/ident/set_thread_flag).
>
> I see, I think I could not reproduce this issue because I already
> reverted the original commit in favor of a different approach on
> linux-next (see commit 2404269bc4e77a67875c8db6667be34c9913c96e).
>
> Let me know if this commit resolve the issue and thanks for reaching out.
>

Cherry-picking commit 2404269bc4e77a67875c8db6667be34c9913c96e on top
of 4.14-rc1 resolves the issue.
Thanks.

>>
>> Regards,
>> Jonathan
>>
>> On 20 September 2017 at 00:32, Thomas Garnier <thgarnie@google.com> wrote:
>> > On Tue, Sep 19, 2017 at 4:50 AM, Jonathan Liu <net147@gmail.com> wrote:
>> >> Fixes "implicit declaration of function" compile error for out-of-tree
>> >> kernel modules including asm/uaccess.h.
>> >
>> > I failed to reproduce this issue by creating an out of tree module
>> > with a separate file (with only uaccess.h). Are you using a special
>> > config?
>> >
>> > Looking at the headers on uaccess.h. You get thread_info through:
>> >
>> >  asm/domain.h -> asm/thread_info.h
>> >
>> >>
>> >> Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-mode return")
>> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> >> ---
>> >>  arch/arm/include/asm/uaccess.h | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
>> >> index 87936dd5d151..13d1877ffb75 100644
>> >> --- a/arch/arm/include/asm/uaccess.h
>> >> +++ b/arch/arm/include/asm/uaccess.h
>> >> @@ -17,6 +17,7 @@
>> >>  #include <asm/unified.h>
>> >>  #include <asm/compiler.h>
>> >>
>> >> +#include <linux/thread_info.h>
>> >>  #include <asm/extable.h>
>> >>
>> >>  /*
>> >> --
>> >> 2.13.2
>> >>
>> >
>> >
>> >
>> > --
>> > Thomas
>
>
>
>
> --
> Thomas

Regards,
Jonathan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: uaccess: Add missing include for set_thread_flag Jonathan Liu <net147@gmail.com> - 2017-09-19 13:50 +0200
  Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag Thomas Garnier <thgarnie@google.com> - 2017-09-19 16:40 +0200
    Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag Jonathan Liu <net147@gmail.com> - 2017-09-19 23:40 +0200
      Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag Thomas Garnier <thgarnie@google.com> - 2017-09-20 18:40 +0200
        Re: [PATCH] ARM: uaccess: Add missing include for set_thread_flag Jonathan Liu <net147@gmail.com> - 2017-09-21 00:10 +0200

csiph-web