Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h

From	Shuah Khan <shuah@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h
Date	2017-09-21 00:50 +0200
Message-ID	<urVYD-MK-29@gated-at.bofh.it> (permalink)
References	<uneyR-6Vy-13@gated-at.bofh.it> <unhZN-18K-17@gated-at.bofh.it> <unij8-1eK-11@gated-at.bofh.it> <urVlU-yv-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/20/2017 04:02 PM, Kees Cook wrote:
> On Thu, Sep 7, 2017 at 8:36 PM, Kees Cook <keescook@chromium.org> wrote:
>> On Thu, Sep 7, 2017 at 8:19 PM, Seth Forshee <seth.forshee@canonical.com> wrote:
>>> On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote:
>>>> The 2.26 release of glibc changed how siginfo_t is defined, and the earlier
>>>> work-around to using the kernel definition are no longer needed. The old
>>>> way needs to stay around for a while, though.
>>>>
>>>> Reported-by: Seth Forshee <seth.forshee@canonical.com>
>>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>>> Cc: Will Drewry <wad@chromium.org>
>>>> Cc: Shuah Khan <shuah@kernel.org>
>>>> Cc: linux-kselftest@vger.kernel.org
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>>> ---
>>>> Seth, can you double check this to confirm it works for you too? This builds
>>>> and tests correctly for me on both Ubuntu 17.10 (-proposed) with glibc 2.26
>>>> and with earlier distros with 2.24, etc.
>>>
>>> It builds and tests correctly for me too, with both glibc 2.26 and 2.24.
>>>
>>> Tested-by: Seth Forshee <seth.forshee@canonical.com>
>>
>> Awesome, thanks!
>>
>> Shuah, is it possible to land this for v4.14? If it has to wait,
>> that's probably okay, as I've marked it for -stable, so it'll get
>> where it needs to be eventually. :)
> 
> Friendly ping, Shuah, are you able to take this?
> 
> Thanks!
> 
> -Kees
> 

Yes I can this into 4.14-rc2 or rc3. Thanks for the ping.

-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h Kees Cook <keescook@chromium.org> - 2017-09-21 00:10 +0200
  Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h Shuah Khan <shuah@kernel.org> - 2017-09-21 00:50 +0200

csiph-web