[PATCH 2/2] powerpc/pseries: fix parent_dn reference leak in add_dt_node()

From	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] powerpc/pseries: fix parent_dn reference leak in add_dt_node()
Date	2017-09-20 23:10 +0200
Message-ID	<urUpP-8nU-3@gated-at.bofh.it> (permalink)
References	<upWFr-1Yr-3@gated-at.bofh.it> <urUpP-8nU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

A reference to the parent device node is held by add_dt_node() for the
node to be added. If the call to dlpar_configure_connector() fails
add_dt_node() returns ENOENT and that reference is not freed.

Add a call to of_node_put(parent_dn) prior to bailing out after a failed
dlpar_configure_connector() call.

Cc: stable@vger.kernel.org # v3.12+
Fixes: 8d5ff320766f ("powerpc/pseries: Make dlpar_configure_connector parent node aware")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
---
 arch/powerpc/platforms/pseries/mobility.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index 210ce63..f7042ad 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -226,8 +226,10 @@ static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
 		return -ENOENT;
 
 	dn = dlpar_configure_connector(drc_index, parent_dn);
-	if (!dn)
+	if (!dn) {
+		of_node_put(parent_dn);
 		return -ENOENT;
+	}
 
 	rc = dlpar_attach_node(dn, parent_dn);
 	if (rc)
-- 
1.8.3.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/2] powerpc/pseries: fix parent_dn reference leak in add_dt_node() Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-09-20 23:10 +0200

csiph-web