[RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	[RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking
Date	2017-09-20 22:00 +0200
Message-ID	<urTk6-7sy-35@gated-at.bofh.it> (permalink)
References	<urTk5-7sy-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

It has been noticed that the dwc2 udc state reporting doesn't
seem to work (at least on HiKey boards). Where after the initial
setup, the sysfs /sys/class/udc/f72c0000.usb/state file would
report "configured" no matter the state of the OTG port.

This patch adds a call so that we report to the UDC layer when
the gadget device is disconnected.

Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Guodong Xu <guodong.xu@linaro.org>
Cc: Amit Pundir <amit.pundir@linaro.org>
Cc: YongQin Liu <yongqin.liu@linaro.org>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Chen Yu <chenyu56@huawei.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Reported-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/usb/dwc2/gadget.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 7fd0e38..603c216 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3202,6 +3202,8 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg)
 
 	call_gadget(hsotg, disconnect);
 	hsotg->lx_state = DWC2_L3;
+
+	usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED);
 }
 
 /**
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey John Stultz <john.stultz@linaro.org> - 2017-09-20 22:00 +0200
  [RESEND x2][PATCH 2/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode John Stultz <john.stultz@linaro.org> - 2017-09-20 22:00 +0200
  [RESEND x2][PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling John Stultz <john.stultz@linaro.org> - 2017-09-20 22:00 +0200
  [RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking John Stultz <john.stultz@linaro.org> - 2017-09-20 22:00 +0200

csiph-web