Re: [PATCH] PM / OPP: Handle return value of kasprintf

From	arvind <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / OPP: Handle return value of kasprintf
Date	2017-09-20 19:00 +0200
Message-ID	<urQvT-5Dp-3@gated-at.bofh.it> (permalink)
References	<urHiX-8bg-49@gated-at.bofh.it> <urLcR-2iJ-13@gated-at.bofh.it> <urOu6-4lW-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Wednesday 20 September 2017 08:19 PM, Viresh Kumar wrote:
> On 20-09-17, 04:17, Joe Perches wrote:
>> On Wed, 2017-09-20 at 12:29 +0530, Arvind Yadav wrote:
>>> kasprintf() can fail here and we must check its return value.
>> []
>>> diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c
>> []
>>> @@ -45,7 +45,8 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
>>>   
>>>   	for (i = 0; i < opp_table->regulator_count; i++) {
>>>   		name = kasprintf(GFP_KERNEL, "supply-%d", i);
>>> -
>>> +		if (!name)
>>> +			return false;
>>>   		/* Create per-opp directory */
>>>   		d = debugfs_create_dir(name, pdentry);
>> Probably more sensible to avoid the kasprintf/kfree
>> and just have
>> 	char name[20];
>> on the stack
> Sure.
>
> @Arvind: I will let you write that patch.
Yes, I will do.
>
~arvind

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PM / OPP: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 09:10 +0200
  Re: [PATCH] PM / OPP: Handle return value of kasprintf Joe Perches <joe@perches.com> - 2017-09-20 13:20 +0200
    Re: [PATCH] PM / OPP: Handle return value of kasprintf Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-20 16:50 +0200
      Re: [PATCH] PM / OPP: Handle return value of kasprintf arvind <arvind.yadav.cs@gmail.com> - 2017-09-20 19:00 +0200

csiph-web