Re: [media] Siano: Use common error handling code in smsusb_init_device()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [media] Siano: Use common error handling code in smsusb_init_device()
Date	2017-09-20 19:20 +0200
Message-ID	<urQPg-602-13@gated-at.bofh.it> (permalink)
References	<urMBY-354-15@gated-at.bofh.it> <urNHH-3OJ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> If smscore_register_device() succeeds then mdev is freed when we call
> smsusb_term_device(intf);  The call tree is:

Thanks for your constructive information.


How do you think about another implementation detail in this function then?

May the statement “kfree(mdev);” be executed before “smsusb_term_device(intf);”
in one if branch?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] Siano: Use common error handling code in  smsusb_init_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-20 14:50 +0200
  Re: [PATCH] [media] Siano: Use common error handling code in  smsusb_init_device() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-20 16:00 +0200
    Re: [media] Siano: Use common error handling code in  smsusb_init_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-20 19:20 +0200

csiph-web