Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1735819

Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check
Date 2017-09-20 17:10 +0200
Message-ID <urONs-4IC-13@gated-at.bofh.it> (permalink)
References <urDIl-5IT-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Sep 19, 2017 at 11:11:11PM -0400, Meng Xu wrote:
> Since right after the user copy, we are going to
> memset(&karg, 0, sizeof(karg)), I guess an access_ok check is enough?

The right thing is to remove it entirely.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mpt3sas: downgrade full copy_from_user to access_ok check Meng Xu <mengxu.gatech@gmail.com> - 2017-09-20 05:20 +0200
  Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check Christoph Hellwig <hch@infradead.org> - 2017-09-20 17:10 +0200
  Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-21 05:30 +0200
    Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check Meng Xu <mengxu.gatech@gmail.com> - 2017-09-21 05:40 +0200

csiph-web