[PATCH] scsi: libfc: fix potential null lport dereference

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] scsi: libfc: fix potential null lport dereference
Date	2017-09-20 15:30 +0200
Message-ID	<urNeF-3Dk-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

Don't pass a null lport to FC_LPORT_DBG as this causes a null pointer
dereference when accessing lport->host and lport->port_id. Instead
use the FC_CHECK_LOGGING macro to print the kernel message via pr_info.

Detected by CoverityScan, CID#113198 ("Dereference after null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/libfc/fc_exch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 42bcf7f3a0f9..46d842d238f1 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -2603,8 +2603,8 @@ void fc_exch_recv(struct fc_lport *lport, struct fc_frame *fp)
 
 	/* lport lock ? */
 	if (!lport || lport->state == LPORT_ST_DISABLED) {
-		FC_LPORT_DBG(lport, "Receiving frames for an lport that "
-			     "has not been initialized correctly\n");
+		FC_CHECK_LOGGING(FC_LPORT_LOGGING,
+				 pr_info("Receiving frames for an lport that has not been initialized correctly\n"));
 		fc_frame_free(fp);
 		return;
 	}
-- 
2.14.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] scsi: libfc: fix potential null lport dereference Colin King <colin.king@canonical.com> - 2017-09-20 15:30 +0200

csiph-web