Re: [PATCH] ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user
Date	2017-09-20 13:10 +0200
Message-ID	<urL3b-2f1-3@gated-at.bofh.it> (permalink)
References	<ur7p8-ju-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 18, 2017 at 05:47:38PM +0100, Will Deacon wrote:
> Commit 553f770ef71b ("ipc: move compat shmctl to native") moved the
> compat IPC syscall handling into ipc/shm.c and refactored the struct
> accessors in the process. Unfortunately, the call to
> copy_compat_shmid_to_user when handling a compat {IPC,SHM}_STAT command
> gets the arguments the wrong way round, passing a kernel stack address
> as the user buffer (destination) and the user buffer as the kernel stack
> address (source).
> 
> This patch fixes the parameter ordering so the buffers are accessed
> correctly.

ACK, will push to Linus tonight...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user Will Deacon <will.deacon@arm.com> - 2017-09-18 18:50 +0200
  Re: [PATCH] ipc/shm: Fix order of parameters when calling  copy_compat_shmid_to_user Will Deacon <will.deacon@arm.com> - 2017-09-20 11:50 +0200
  Re: [PATCH] ipc/shm: Fix order of parameters when calling  copy_compat_shmid_to_user Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-20 13:10 +0200

csiph-web