Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr_write()

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr_write()
Date	2017-09-20 10:20 +0200
Message-ID	<urIoF-qm-7@gated-at.bofh.it> (permalink)
References	<ur265-5yD-21@gated-at.bofh.it> <ur3bQ-6bT-17@gated-at.bofh.it> <ur6CK-8bR-5@gated-at.bofh.it> <urH9g-7S7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/09/2017 08:35, Yu Zhang wrote:
> 
> 2 reasons I did not choose to change kvm_cpuid(): 1> like Jim's
> comments, kvm_cpuid() will eventually write the *eax - *edx no
> matter a cpuid entry is found or not; 2> currently, return value of
> kvm_cpuid() is either true when an entry is found or false otherwise.
> We can change kvm_cpuid() to check the pointers of GPRs against NULL
> and return false immediately. Then the false value would have 2
> different meanings - entry not found, or invalid params.
> 
> Paolo, any suggestion? :-)

Radim, has already sent this version to Linus. :)

Paolo

Thread

[PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr_write() Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-09-18 13:10 +0200
  Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in  check_cr_write() David Hildenbrand <david@redhat.com> - 2017-09-18 14:20 +0200
    Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in check_cr_write() Jim Mattson <jmattson@google.com> - 2017-09-18 18:00 +0200
      Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in  check_cr_write() Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-09-20 09:00 +0200
        Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in  check_cr_write() Paolo Bonzini <pbonzini@redhat.com> - 2017-09-20 10:20 +0200
          Re: [PATCH] KVM: x86: Fix the NULL pointer parameter in  check_cr_write() Yu Zhang <yu.c.zhang@linux.intel.com> - 2017-09-20 11:00 +0200

csiph-web