Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data

From	Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data
Date	2017-09-20 09:30 +0200
Message-ID	<urHCi-8iH-33@gated-at.bofh.it> (permalink)
References	<urvKQ-xs-57@gated-at.bofh.it> <urH9g-7S7-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 20, 2017 at 08:58:14AM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote:
> > The usage of of_device_get_match_data reduce the code size a bit.
> > Furthermore, it prevents an improbable dereference when
> > of_match_device() return NULL.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> 
> The prefix of your commit title is wrong, this isn't about the GPADC.
> 
> Once fixed,
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Maxime
> 

A copy/paste error, sorry
I will resend
thanks
Corentin Labbe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-19 20:50 +0200
  Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use  of_device_get_match_data Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-20 09:00 +0200
    Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use  of_device_get_match_data Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-20 09:30 +0200

csiph-web