Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall

From	Joel Stanley <joel@jms.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall
Date	2017-09-20 08:20 +0200
Message-ID	<urGwy-7DX-5@gated-at.bofh.it> (permalink)
References	<urFTP-79w-3@gated-at.bofh.it> <urFTQ-79w-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Probing at device_initcall time lead to perverse cases where the
> watchdog was probed after, say, I2C devices, which then leaves a
> potentially running watchdog at the mercy of I2C device behaviour and
> bus conditions.
>
> Load the watchdog driver early to ensure that the kernel is patting it
> well before initialising peripherals.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

I agree that we need to make sure the watchdog driver is loaded
earlier. I think this is the correct method, but I'll defer to Guenter
on this one.

Cheers,

Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall Andrew Jeffery <andrew@aj.id.au> - 2017-09-20 07:40 +0200
  Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall Joel Stanley <joel@jms.id.au> - 2017-09-20 08:20 +0200

csiph-web