Re: [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state

From	Joel Stanley <joel@jms.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state
Date	2017-09-20 08:10 +0200
Message-ID	<urGmR-7Am-7@gated-at.bofh.it> (permalink)
References	<urFTP-79w-3@gated-at.bofh.it> <urFTQ-79w-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> An unintended post-condition of probe() is that the watchdog is
> disabled. This behaviour was introduced by an unnecessary write to the
> control register to configure the hardware based on the devicetree. The
> write is unnecessary because the cached control value that is
> manipulated by the code parsing the devicetree is eventually written by
> aspeed_wdt_enable(), which is when we care how the control register
> should be configured.
>
> Remove the write to restore expected behaviour.
>
> Fixes: b7f0b8ad25f3 ("drivers/watchdog: ASPEED reference dev tree properties for config")
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Reviewed-by: Joel Stanley <joel@jms.id.au>

Thanks,

Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state Andrew Jeffery <andrew@aj.id.au> - 2017-09-20 07:40 +0200
  Re: [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state Joel Stanley <joel@jms.id.au> - 2017-09-20 08:10 +0200

csiph-web