Re: [PATCH] powerpc: make irq_chip const, initdata and initconst

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst
Date	Wed, 20 Sep 2017 08:40:02 +0200
Message-ID	<urGPU-7L3-9@gated-at.bofh.it> (permalink)
References	<ur53Z-7mI-17@gated-at.bofh.it> <urGGd-7Hy-9@gated-at.bofh.it>
X-Original-To	Michael Ellerman <mpe@ellerman.id.au>
X-Ironport-Av	E=Sophos;i="5.42,420,1500933600"; d="scan'208";a="238087821"
X-X-Sender	jll@hadrien
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Bhumika Goyal <bhumirks@gmail.com>, benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 20 Sep 2017 08:34:00 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.20.1709200833320.4638@hadrien>
X-Original-References	<1505743967-19448-1-git-send-email-bhumirks@gmail.com> <87o9q5lwgq.fsf@concordia.ellerman.id.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1735554

Show key headers only | View raw


On Wed, 20 Sep 2017, Michael Ellerman wrote:

> Bhumika Goyal <bhumirks@gmail.com> writes:
>
> > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are
> > used only as a copy operation. This usage is during init, so make them
> > __initconst too.
> > Make mpic_ipi_chip __initdata as it is only modified during the init
> > phase and there is no reference of it anywhere after init.
>
> The change log doesn't seem to match the code.
>
> It's mpic_tm_chip which you marked __initdata, and that looks wrong, as
> we keep a pointer to it here:
>
> 	mpic->hc_tm = mpic_tm_chip;

This looks like a memory copy.

julia

Thread

[PATCH] powerpc: make irq_chip const, __initdata and __initconst Bhumika Goyal <bhumirks@gmail.com> - 2017-09-18 16:20 +0200
  Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst Michael Ellerman <mpe@ellerman.id.au> - 2017-09-20 08:30 +0200
    Re: [PATCH] powerpc: make irq_chip const, __initdata and  __initconst Julia Lawall <julia.lawall@lip6.fr> - 2017-09-20 08:40 +0200
      Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst Michael Ellerman <mpe@ellerman.id.au> - 2017-09-20 13:20 +0200

csiph-web