Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735381

Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang

Show all headers | View raw

On Tue, Sep 19, 2017 at 01:45:28PM -0500, Josh Poimboeuf wrote:
> For inline asm statements which have a CALL instruction, we list the
> stack pointer as a constraint to convince GCC to ensure the frame
> pointer is set up first:
> 
>   static inline void foo()
>   {
>   	register void *__sp asm(_ASM_SP);
>   	asm("call bar" : "+r" (__sp))
>   }
> 
> Unfortunately, that pattern causes clang to corrupt the stack pointer.
> 
> There's actually an easier way to achieve the same goal in GCC, without
> causing trouble for clang.  If we declare the stack pointer register
> variable as a global variable, and remove the constraint altogether,
> that convinces GCC to always set up the frame pointer before inserting
> *any* inline asm.
> 
> It basically acts as if *every* inline asm statement has a CALL
> instruction.  It's a bit overkill, but the performance impact should be
> negligible.
> 
> Here are the vmlinux .text size differences with the following configs
> on GCC:
> 
> - defconfig
> - defconfig without frame pointers
> - Fedora distro config
> - Fedora distro config without frame pointers
> 
> 	defconfig	defconfig-nofp	distro		distro-nofp
> before	9796300		9466764		9076191		8789745
> after	9796941		9462859		9076381		8785325
> 
> With frame pointers, the text size increases slightly.  Without frame
> pointers, the text size decreases, and a little more significantly.
> 
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

NAK - kbuild bot is reporting some cases where this patch doesn't force
the frame pointer setup.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 20:50 +0200
  Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Alexander Potapenko <glider@google.com> - 2017-09-20 00:00 +0200
    Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Alexander Potapenko <glider@google.com> - 2017-09-20 00:30 +0200
      Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-20 03:50 +0200
  Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-20 03:20 +0200
    Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-20 20:00 +0200
  Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Dmitry Vyukov <dvyukov@google.com> - 2017-09-20 19:40 +0200
    Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang "H. Peter Anvin" <hpa@zytor.com> - 2017-09-20 20:00 +0200
      Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Dmitry Vyukov <dvyukov@google.com> - 2017-09-20 20:10 +0200
        Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-20 23:10 +0200
          Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Andy Lutomirski <luto@amacapital.net> - 2017-09-20 23:20 +0200
            Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Dmitry Vyukov <dvyukov@google.com> - 2017-09-21 10:20 +0200
              Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Brian Gerst <brgerst@gmail.com> - 2017-09-21 14:00 +0200
                Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Dmitry Vyukov <dvyukov@google.com> - 2017-09-21 14:20 +0200
  Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang "H. Peter Anvin" <hpa@zytor.com> - 2017-09-20 19:50 +0200
    Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-20 20:00 +0200
      Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Ingo Molnar <mingo@kernel.org> - 2017-09-21 17:40 +0200
        Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-21 18:20 +0200

csiph-web