Change of set_fs() in uaccess.h breaks this header being self contained for x86 (4.14-rc1)

From	Stefan Mätje <Stefan.Maetje@esd.eu>
Newsgroups	linux.kernel
Subject	Change of set_fs() in uaccess.h breaks this header being self contained for x86 (4.14-rc1)
Date	2017-09-18 20:50 +0200
Message-ID	<ur9hf-1yZ-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

there is a change in Linus' mainline kernel
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/x86/include/asm/uaccess.h?id=6c51e67b64d169419fb13318035bb442f9176612)
that changes the set_fs() macro into an inline function.

This breaks the build of an out of kernel driver I maintain with this
message:

./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to
incomplete type

set_fs() is referencing the "current" pointer which is of type "struct
task_struct" declared in include/linux/sched.h.

Before the change set_fs() was a macro. Because I don't use it it was of
no concern for me. But now the compiler needs to compile the inline
function set_fs() and fails.

Should I add the needed <linux/sched.h> myself in my code or will that
be changed / fixed in the <asm/uaccess.h> header by including the
missing header.

Thanks for any advice.

Best regards,
	Stefan Mätje

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Change of set_fs() in uaccess.h breaks this header being self  contained for x86 (4.14-rc1) Stefan Mätje <Stefan.Maetje@esd.eu> - 2017-09-18 20:50 +0200

csiph-web