Re: [PATCH] drm: pl111: constify amba_id

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: pl111: constify amba_id
Date	2017-09-18 19:30 +0200
Message-ID	<ur81P-L0-9@gated-at.bofh.it> (permalink)
References	<uhGxP-2Nf-3@gated-at.bofh.it> <uhGxP-2Nf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Arvind Yadav <arvind.yadav.cs@gmail.com> writes:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index ac8771b..522875c 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba_dev)
>  	return 0;
>  }
>  
> -static struct amba_id pl111_id_table[] = {
> +static const struct amba_id pl111_id_table[] = {
>  	{
>  		.id = 0x00041111,
>  		.mask = 0x000fffff,
> -- 
> 2.7.4

Sorry about dropping your patch here -- Linus was working on a bigger
series for pl110 support that also happened to fix this.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drm: pl111: constify amba_id Eric Anholt <eric@anholt.net> - 2017-09-18 19:30 +0200

csiph-web