Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table
Date	2017-09-18 18:30 +0200
Message-ID	<ur75M-b2-33@gated-at.bofh.it> (permalink)
References	<uotPb-1xj-3@gated-at.bofh.it> <uotPb-1xj-13@gated-at.bofh.it> <uoA4h-5TQ-1@gated-at.bofh.it> <uoP3k-7qx-9@gated-at.bofh.it> <ur3vc-6je-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 18, 2017 at 02:38:03PM +0200, Thiebaud Weksteen wrote:
> On Tue, Sep 12, 2017 at 10:48 AM, Thiebaud Weksteen <tweek@google.com> wrote:
> > On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote:
> >> On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote:
> >>
> >> >     chip->bin_log_seqops.chip = chip;
> >> > -   if (chip->flags & TPM_CHIP_FLAG_TPM2)
> >> > +
> >> > +   if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 ||
> >> > +       (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2)))
> >> >             chip->bin_log_seqops.seqops =
> >> >                     &tpm2_binary_b_measurements_seqops;
> >>
> >> Lets have all the read_log_* versions return the postitive log_version
> >> and get rid of the chip->flags check here.
> >>
> >> ie Doesn't ACPI always return the TPM 1 version?
> >
> > That is my understanding. Ashley, Nayna, could you confirm the format
> > version expected by tpm_of? Could it be both?
> >
> 
> I've changed the returned code for ACPI but not for DeviceTree.
> Without confirmation for tpm_of, I am reluctant to modify the current
> behaviour.

Move the TPM_CHIP_FLAG_TPM2 check into tpm_of to keep the current behavior
but still return the code..

Jason

Thread

[PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen <tweek@google.com> - 2017-09-11 12:10 +0200
  Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-09-11 18:50 +0200
    Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen <tweek@google.com> - 2017-09-12 10:50 +0200
      Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen <tweek@google.com> - 2017-09-18 14:40 +0200
        Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-09-18 18:30 +0200
  Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table kbuild test robot <lkp@intel.com> - 2017-09-13 18:30 +0200
    Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen <tweek@google.com> - 2017-09-13 18:50 +0200
  Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-14 20:50 +0200
    Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen <tweek@google.com> - 2017-09-18 14:40 +0200

csiph-web