Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734276

[PATCH] idr: fix comment for idr_replace()

Show all headers | View raw

From: Eric Biggers <ebiggers@google.com>

idr_replace() returns the old value on success, not 0.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 lib/idr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/idr.c b/lib/idr.c
index f9adf4805fd7..edd9b2be1651 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -146,8 +146,8 @@ EXPORT_SYMBOL(idr_get_next_ext);
  * idr_alloc() and idr_remove() (as long as the ID being removed is not
  * the one being replaced!).
  *
- * Returns: 0 on success.  %-ENOENT indicates that @id was not found.
- * %-EINVAL indicates that @id or @ptr were not valid.
+ * Returns: the old value on success.  %-ENOENT indicates that @id was not
+ * found.  %-EINVAL indicates that @id or @ptr were not valid.
  */
 void *idr_replace(struct idr *idr, void *ptr, int id)
 {
-- 
2.14.1.690.gbb1197296e-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] idr: fix comment for idr_replace() Eric Biggers <ebiggers3@gmail.com> - 2017-09-18 18:30 +0200

csiph-web