Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734264

Re: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()'

Show all headers | View raw

Hey,

I don't have any relation to the rapidio code short of making a small 
change to an API it used. But I reviewed both patches and they look 
correct to me.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Logan

On 17/09/17 04:33 PM, Christophe JAILLET wrote:
> These 2 patches are really close and are both related to error handling
> in 'rio_dma_transfer()'.
> The first one fixes some resources leak in case of error.
> The 2nd one fixes a test so that the corresponding error can be handled
> correctly.
> 
> I've splitted this into 2 paches because the first one looks trivial to me.
> But the 2nd one should require more attention, IMO. The existing error
> handling was dead code because 'dma_map_sg()' can not return -EFAULT. So
> this error handling code has never been executed/tested and I can't test it
> myself.
> 
> Christophe JAILLET (2):
>    rapidio: Fix resources leak in error handling path in
>      'rio_dma_transfer()'
>    rapidio: Fix an error handling in 'rio_dma_transfer()'
> 
>   drivers/rapidio/devices/rio_mport_cdev.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-18 00:40 +0200
  [PATCH 2/2] rapidio: Fix an error handling in 'rio_dma_transfer()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-18 00:40 +0200
  [PATCH 1/2] rapidio: Fix resources leak in error handling path in 'rio_dma_transfer()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-18 00:40 +0200
  Re: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Logan Gunthorpe <logang@deltatee.com> - 2017-09-18 18:10 +0200

csiph-web