Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734164

Re: [PATCH] android: binder: fix type mismatch warning

Show all headers | View raw

On Tue, Sep 05, 2017 at 10:56:13AM +0200, Arnd Bergmann wrote:
> Allowing binder to expose the 64-bit API on 32-bit kernels caused a
> build warning:
> 
> drivers/android/binder.c: In function 'binder_transaction_buffer_release':
> drivers/android/binder.c:2220:15: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     fd_array = (u32 *)(parent_buffer + fda->parent_offset);
>                ^
> drivers/android/binder.c: In function 'binder_translate_fd_array':
> drivers/android/binder.c:2445:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>   fd_array = (u32 *)(parent_buffer + fda->parent_offset);
>              ^
> drivers/android/binder.c: In function 'binder_fixup_parent':
> drivers/android/binder.c:2511:18: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 
> This adds extra type casts to avoid the warning.
> 
> However, there is another problem with the Kconfig option: turning
> it on or off creates two incompatible ABI versions, a kernel that
> has this enabled cannot run user space that was built without it
> or vice versa. A better solution might be to leave the option hidden
> until the binder code is fixed to deal with both ABI versions.

I don't know if that is ever going to be fixed, as it's not an issue
that you will ever see "in the wild" from what I can tell...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] android: binder: fix type mismatch warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-18 16:10 +0200
  Re: [PATCH] android: binder: fix type mismatch warning Arnd Bergmann <arnd@arndb.de> - 2017-09-18 17:40 +0200
    Re: [PATCH] android: binder: fix type mismatch warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-18 18:00 +0200
      Re: [PATCH] android: binder: fix type mismatch warning Christoph Hellwig <hch@infradead.org> - 2017-09-18 18:30 +0200
        Re: [PATCH] android: binder: fix type mismatch warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-18 18:40 +0200
        Re: [PATCH] android: binder: fix type mismatch warning Arnd Bergmann <arnd@arndb.de> - 2017-09-18 21:50 +0200
          Re: [PATCH] android: binder: fix type mismatch warning Martijn Coenen <maco@android.com> - 2017-09-20 11:10 +0200
            Re: [PATCH] android: binder: fix type mismatch warning Arnd Bergmann <arnd@arndb.de> - 2017-09-20 12:00 +0200
              Re: [PATCH] android: binder: fix type mismatch warning Martijn Coenen <maco@android.com> - 2017-09-20 12:30 +0200
                Re: [PATCH] android: binder: fix type mismatch warning Arnd Bergmann <arnd@arndb.de> - 2017-09-20 15:40 +0200
                Re: [PATCH] android: binder: fix type mismatch warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-21 09:50 +0200
                Re: [PATCH] android: binder: fix type mismatch warning Martijn Coenen <maco@android.com> - 2017-09-22 09:10 +0200
                Re: [PATCH] android: binder: fix type mismatch warning Arnd Bergmann <arnd@arndb.de> - 2017-09-22 11:20 +0200
                Re: [PATCH] android: binder: fix type mismatch warning Martijn Coenen <maco@android.com> - 2017-09-22 14:50 +0200
    Re: [PATCH] android: binder: fix type mismatch warning Christoph Hellwig <hch@infradead.org> - 2017-09-18 18:00 +0200

csiph-web