Re: [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers

From	Milian Wolff <milian.wolff@kdab.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers
Date	2017-09-18 14:50 +0200
Message-ID	<ur3ER-6mo-7@gated-at.bofh.it> (permalink)
References	<umJ21-2yd-3@gated-at.bofh.it> <umJbH-2R0-3@gated-at.bofh.it> <ur2Su-5Pg-13@gated-at.bofh.it>
Organization	KDAB

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Monday, September 18, 2017 1:56:19 PM CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:49PM +0200, Milian Wolff wrote:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
> 
> so you're removing all the inline callchain implementation
> in this patch and adding it back in following patches?
> 
> any chance you could change it gradualy? it's hard to track
> in review if you added everything that you removed ;-)

As I said before, this approach is completely different from the previous one. 
There is no way to change it more gradually than what I have done. At least, I 
cannot think of one.

Bye

-- 
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 01/13] perf report: remove code to handle inline  frames from browsers Jiri Olsa <jolsa@redhat.com> - 2017-09-18 14:00 +0200
  Re: [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers Milian Wolff <milian.wolff@kdab.com> - 2017-09-18 14:50 +0200

csiph-web