Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734075

[PATCH] xfs: remove redundant re-initialization of total_nr_pages

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

Variable total_nr_pages is being initialized and then updated with
the same value, this latter assignment is redundant and can be
removed.  Cleans up clang build warning:

Value stored to 'total_nr_pages' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/xfs/xfs_buf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index da14658da310..2f97c12ca75e 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1258,8 +1258,6 @@ xfs_buf_ioapply_map(
 	int		size;
 	int		offset;
 
-	total_nr_pages = bp->b_page_count;
-
 	/* skip the pages in the buffer before the start offset */
 	page_index = 0;
 	offset = *buf_offset;
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xfs: remove redundant re-initialization of total_nr_pages Colin King <colin.king@canonical.com> - 2017-09-18 14:10 +0200
  Re: [PATCH] xfs: remove redundant re-initialization of total_nr_pages Brian Foster <bfoster@redhat.com> - 2017-09-18 14:50 +0200
  Re: [PATCH] xfs: remove redundant re-initialization of total_nr_pages "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-09-18 22:40 +0200

csiph-web