Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback

From	"Yang, Wenyou" <Wenyou.Yang@Microchip.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback
Date	2017-09-18 11:30 +0200
Message-ID	<ur0xm-4fK-65@gated-at.bofh.it> (permalink)
References	<uqY2t-2oA-3@gated-at.bofh.it> <uqY2u-2oA-21@gated-at.bofh.it> <uqYOS-36l-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sakari,


On 2017/9/18 15:36, Sakari Ailus wrote:
> Hi Wenyou,
>
> On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote:
>> @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd,
>>   		ret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL);
>>   		if (ret)
>>   			return ret;
>> -		cfg->try_fmt = format->format;
>> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
>> +		struct v4l2_mbus_framefmt *mbus_fmt;
> This will emit a compiler warning at least.
Thank you for your review.
Will be fixed in next version.
>
>> +
>> +		mbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
>> +		*mbus_fmt = format->format;
>>   		return 0;
>> +#else
>> +		return -ENOTTY;
>> +#endif
>>   	}
>>   
>>   	ret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize);

Best Regards,
Wenyou Yang

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] media: ov7670: Add entity init and power operation Wenyou Yang <wenyou.yang@microchip.com> - 2017-09-18 08:50 +0200
  [PATCH v4 1/3] media: ov7670: Add entity pads initialization Wenyou Yang <wenyou.yang@microchip.com> - 2017-09-18 08:50 +0200
  [PATCH v4 3/3] media: ov7670: Add the s_power operation Wenyou Yang <wenyou.yang@microchip.com> - 2017-09-18 08:50 +0200
    Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation Sakari Ailus <sakari.ailus@iki.fi> - 2017-09-18 09:40 +0200
      Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-09-18 11:30 +0200
        Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation Sakari Ailus <sakari.ailus@iki.fi> - 2017-09-18 15:30 +0200
  [PATCH v4 2/3] media: ov7670: Add the get_fmt callback Wenyou Yang <wenyou.yang@microchip.com> - 2017-09-18 08:50 +0200
    Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback Sakari Ailus <sakari.ailus@iki.fi> - 2017-09-18 09:40 +0200
      Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-09-18 11:30 +0200

csiph-web