Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1733882

Re: [PATCH] kbuild: rpm-pkg: delete firmware_install to fix build error

Show all headers | View raw

On Mon, Sep 18, 2017 at 06:12:36PM +0900, Masahiro Yamada wrote:
> Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted
> in-kernel firmware support, including "make firmware_install".
> 
> Since then, "make rpm-pkg" / "make binrpm-pkg" fails to build with
> the error:
> 
>   make[2]: *** No rule to make target `firmware_install'.  Stop.
> 
> Commit df85b2d767aa ("firmware: Restore support for built-in firmware")
> restored the build infrastructure for CONFIG_EXTRA_FIRMWARE, but this
> is out of the scope of "make firmware_install".  So, the right thing to
> do is to kill the use of "make firmware_install".
> 
> Fixes: 5620a0d1aacd ("firmware: delete in-kernel firmware")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  scripts/package/mkspec | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Nice find, what's the odds the debian package "script" also needs this
fix?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] kbuild: rpm-pkg: delete firmware_install to fix build  error Greg K-H <gregkh@linuxfoundation.org> - 2017-09-18 11:30 +0200

csiph-web