Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1733219
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] acpi: watchdog: properly initialize resources |
| Date | 2017-09-16 09:00 +0200 |
| Message-ID | <uqff4-6i3-5@gated-at.bofh.it> (permalink) |
| References | <uq4Wm-7vc-9@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, Sep 15, 2017 at 09:55:18PM +0200, Arnd Bergmann wrote:
> We copy a local resource structure into a list, but only
> initialize some of its members, as pointed out by gcc-4.4:
>
> drivers/acpi/acpi_watchdog.c: In function 'acpi_watchdog_init':
> drivers/acpi/acpi_watchdog.c:105: error: 'res.child' may be used uninitialized in this function
> drivers/acpi/acpi_watchdog.c:105: error: 'res.sibling' may be used uninitialized in this function
> drivers/acpi/acpi_watchdog.c:105: error: 'res.parent' may be used uninitialized in this function
> drivers/acpi/acpi_watchdog.c:105: error: 'res.desc' may be used uninitialized in this function
> drivers/acpi/acpi_watchdog.c:105: error: 'res.name' may be used uninitialized in this function
>
> Newer compilers can presumably optimize the uninitialized access
> away entirely and don't warn at all, but rely on the kzalloc()
> to zero the structure first. This adds an explicit initialization
> to force consistent behavior.
>
> Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] acpi: watchdog: properly initialize resources Arnd Bergmann <arnd@arndb.de> - 2017-09-15 22:00 +0200
Re: [PATCH] acpi: watchdog: properly initialize resources Guenter Roeck <linux@roeck-us.net> - 2017-09-16 00:40 +0200
Re: [PATCH] acpi: watchdog: properly initialize resources Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-09-16 09:00 +0200
Re: [PATCH] acpi: watchdog: properly initialize resources "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-09-19 02:00 +0200
csiph-web