Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"
Date	2017-09-18 08:50 +0200
Message-ID	<uqY2u-2oA-13@gated-at.bofh.it> (permalink)
References	<uqpo6-4Pv-13@gated-at.bofh.it> <uqrJf-6yk-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

"Jan H. Schönherr" <jschoenh@amazon.de> writes:

> This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563.
>
> The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
> there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
> gsi values make sense.
>
> As the commit was meant as an early indicator to user space that
> something is wrong, reverting just restores the previous behavior
> where overly large values are ignored when encountered (without
> any direct feedback).
>
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
> ---
>  virt/kvm/eventfd.c | 2 --
>  1 file changed, 2 deletions(-)

Can someone merge this or preferably just send it straight to Linus, the
original patch has broken the powerpc build in mainline.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [mainline][bisected 36ae3c0] Build fail at virt/kvm/eventfd.c:568 "Jan H. Schönherr" <jschoenh@amazon.de> - 2017-09-16 19:50 +0200
  [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD" Jan H. Schönherr <jschoenh@amazon.de> - 2017-09-16 22:20 +0200
    Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD" Michael Ellerman <mpe@ellerman.id.au> - 2017-09-18 08:50 +0200

csiph-web