Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1733527
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/8] [media] cx231xx: Improve six size determinations |
| Date | 2017-09-17 22:20 +0200 |
| Message-ID | <uqOcN-4tM-9@gated-at.bofh.it> (permalink) |
| References | <uqOcN-4tM-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 17 Sep 2017 18:38:50 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 10 +++++----- drivers/media/usb/cx231xx/cx231xx-video.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/usb/cx231xx/cx231xx-dvb.c index 0813f368fb3c..35d98ec948b2 100644 --- a/drivers/media/usb/cx231xx/cx231xx-dvb.c +++ b/drivers/media/usb/cx231xx/cx231xx-dvb.c @@ -611,5 +611,5 @@ static int dvb_init(struct cx231xx *dev) return 0; } - dvb = kzalloc(sizeof(struct cx231xx_dvb), GFP_KERNEL); + dvb = kzalloc(sizeof(*dvb), GFP_KERNEL); if (!dvb) @@ -754,7 +754,7 @@ static int dvb_init(struct cx231xx *dev) si2165_pdata.chip_mode = SI2165_MODE_PLL_XTAL, si2165_pdata.ref_freq_Hz = 16000000, - memset(&info, 0, sizeof(struct i2c_board_info)); + memset(&info, 0, sizeof(info)); strlcpy(info.type, "si2165", I2C_NAME_SIZE); info.addr = 0x64; info.platform_data = &si2165_pdata; @@ -801,7 +801,7 @@ static int dvb_init(struct cx231xx *dev) si2165_pdata.chip_mode = SI2165_MODE_PLL_EXT, si2165_pdata.ref_freq_Hz = 24000000, - memset(&info, 0, sizeof(struct i2c_board_info)); + memset(&info, 0, sizeof(info)); strlcpy(info.type, "si2165", I2C_NAME_SIZE); info.addr = 0x64; info.platform_data = &si2165_pdata; @@ -822,7 +822,7 @@ static int dvb_init(struct cx231xx *dev) dvb->i2c_client_demod = client; - memset(&info, 0, sizeof(struct i2c_board_info)); + memset(&info, 0, sizeof(info)); dev->dvb->frontend->ops.i2c_gate_ctrl = NULL; @@ -869,7 +869,7 @@ static int dvb_init(struct cx231xx *dev) struct i2c_board_info info; struct si2157_config si2157_config; - memset(&info, 0, sizeof(struct i2c_board_info)); + memset(&info, 0, sizeof(info)); dev->dvb->frontend = dvb_attach(lgdt3306a_attach, &hauppauge_955q_lgdt3306a_config, diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index 956f8cbcb454..a12ec3567684 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers/media/usb/cx231xx/cx231xx-video.c @@ -1771,5 +1771,5 @@ static int cx231xx_v4l2_open(struct file *filp) } #endif - fh = kzalloc(sizeof(struct cx231xx_fh), GFP_KERNEL); + fh = kzalloc(sizeof(*fh), GFP_KERNEL); if (!fh) -- 2.14.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] [media] Cx231xx: Adjustments for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:20 +0200 [PATCH 3/8] [media] cx231xx: Improve six size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:20 +0200 [PATCH 2/8] [media] cx231xx: Adjust 56 checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:20 +0200 [PATCH 1/8] [media] cx231xx: Delete eight error messages for a failed memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:20 +0200 [PATCH 5/8] [media] cx231xx: Use common error handling code in dvb_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:30 +0200 [PATCH 4/8] [media] cx231xx: Delete an unnecessary variable initialisation in dvb_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:30 +0200 [PATCH 7/8] [media] cx231xx: Delete an unnecessary variable initialisation in read_eeprom() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:30 +0200 [PATCH 8/8] [media] cx231xx: Use common error handling code in cx231xx_load_firmware() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:30 +0200 [PATCH 6/8] [media] cx231xx: Use common error handling code in read_eeprom() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 22:30 +0200
csiph-web