[PATCH] mtd: spi-nor: Kill check with no effect

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	[PATCH] mtd: spi-nor: Kill check with no effect
Date	2017-09-17 16:20 +0200
Message-ID	<uqIAp-AU-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

header.major is of type u8 and cannot be negative.

Detected by CoverityScan CID#1417858 ("Integer handling issues")

Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable
Parameters (SFDP) tables")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
Cyrille,

I'm not sure what exactly you wanted to test.
Maybe it makes sense casting header.major to s8 before checking against < 0?

Thanks,
//richard
---
 drivers/mtd/spi-nor/spi-nor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d71765739a93..4b86decdf13e 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2252,8 +2252,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
 
 	/* Check the SFDP header version. */
 	if (le32_to_cpu(header.signature) != SFDP_SIGNATURE ||
-	    header.major != SFDP_JESD216_MAJOR ||
-	    header.minor < SFDP_JESD216_MINOR)
+	    header.major != SFDP_JESD216_MAJOR)
 		return -EINVAL;
 
 	/*
-- 
2.13.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: spi-nor: Kill check with no effect Richard Weinberger <richard@nod.at> - 2017-09-17 16:20 +0200
  Re: [PATCH] mtd: spi-nor: Kill check with no effect Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-18 11:50 +0200
    Re: [PATCH] mtd: spi-nor: Kill check with no effect Richard Weinberger <richard@nod.at> - 2017-09-18 15:40 +0200
    Re: [PATCH] mtd: spi-nor: Kill check with no effect Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-09-19 19:20 +0200

csiph-web