Re: [PATCH v2] net: smsc911x: Quieten netif during suspend

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] net: smsc911x: Quieten netif during suspend
Date	2017-09-15 23:30 +0200
Message-ID	<uq6lr-8D-5@gated-at.bofh.it> (permalink)
References	<upjXr-1Yv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Wed, 13 Sep 2017 19:42:05 +0200

> If the network interface is kept running during suspend, the net core
> may call net_device_ops.ndo_start_xmit() while the Ethernet device is
> still suspended, which may lead to a system crash.
> 
> E.g. on sh73a0/kzm9g and r8a73a4/ape6evm, the external Ethernet chip is
> driven by a PM controlled clock.  If the Ethernet registers are accessed
> while the clock is not running, the system will crash with an imprecise
> external abort.
> 
> As this is a race condition with a small time window, it is not so easy
> to trigger at will.  Using pm_test may increase your chances:
> 
>     # echo 0 > /sys/module/printk/parameters/console_suspend
>     # echo platform > /sys/power/pm_test
>     # echo mem > /sys/power/state
> 
> To fix this, make sure the network interface is quietened during
> suspend.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: smsc911x: Quieten netif during suspend Geert Uytterhoeven <geert+renesas@glider.be> - 2017-09-13 19:50 +0200
  Re: [PATCH v2] net: smsc911x: Quieten netif during suspend Florian Fainelli <f.fainelli@gmail.com> - 2017-09-14 01:30 +0200
    Re: [PATCH v2] net: smsc911x: Quieten netif during suspend Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-14 11:20 +0200
  Re: [PATCH v2] net: smsc911x: Quieten netif during suspend David Miller <davem@davemloft.net> - 2017-09-15 23:30 +0200

csiph-web