Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1733081

[PATCH 2/2] [media] ma901: Improve a size determination in usb_ma901radio_probe()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Sep 2017 22:23:42 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/radio/radio-ma901.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/radio/radio-ma901.c b/drivers/media/radio/radio-ma901.c
index c386fbd63703..61d1657f1ee7 100644
--- a/drivers/media/radio/radio-ma901.c
+++ b/drivers/media/radio/radio-ma901.c
@@ -357,5 +357,5 @@ static int usb_ma901radio_probe(struct usb_interface *intf,
 		|| strncmp(dev->manufacturer, "www.masterkit.ru", 16) != 0))
 		return -ENODEV;
 
-	radio = kzalloc(sizeof(struct ma901radio_device), GFP_KERNEL);
+	radio = kzalloc(sizeof(*radio), GFP_KERNEL);
 	if (!radio) {
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] [media] MA901: Adjustments for usb_ma901radio_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-15 22:50 +0200
  [PATCH 2/2] [media] ma901: Improve a size determination in  usb_ma901radio_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-15 22:50 +0200
  [PATCH 1/2] [media] ma901: Delete two error messages for a failed  memory allocation in usb_ma901radio_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-15 22:50 +0200

csiph-web