Re: [PATCH] perf, tools: Improve error messages for missing PMUs

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf, tools: Improve error messages for missing PMUs
Date	2017-09-15 21:10 +0200
Message-ID	<uq49Y-7ct-15@gated-at.bofh.it> (permalink)
References	<upnRo-4qH-11@gated-at.bofh.it> <uq3QC-6Q2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu:
> On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote:
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt,
> >  	memset(&parse_error, 0, sizeof(struct parse_events_error));
> >  	ret = parse_events(perf_evlist, extra_events.buf, &parse_error);
> >  	if (ret) {
> > -		pr_err("Cannot set up events %s\n", extra_events.buf);
> > +                parse_events_print_error(&parse_error, extra_events.buf);
> 
> nit, mixed tabs/spaces indent, other than that:

Fixed that.
 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo

Thread

[PATCH] perf, tools: Improve error messages for missing PMUs Andi Kleen <andi@firstfloor.org> - 2017-09-14 00:00 +0200
  Re: [PATCH] perf, tools: Improve error messages for missing PMUs Jiri Olsa <jolsa@redhat.com> - 2017-09-15 20:50 +0200
    Re: [PATCH] perf, tools: Improve error messages for missing PMUs Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-15 21:10 +0200
  [tip:perf/core] perf pmu: Improve error messages for missing PMUs tip-bot for Andi Kleen <tipbot@zytor.com> - 2017-09-22 18:50 +0200

csiph-web