Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1733012

Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition

Show all headers | View raw

On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:

[..]
> +static struct smem_ptable *qcom_smem_get_ptable(struct qcom_smem *smem)
>  {
> -	struct smem_partition_header *header;
> -	struct smem_ptable_entry *entry;
>  	struct smem_ptable *ptable;
> -	unsigned remote_host;
> -	u32 version, host0, host1;
> -	int i;
> +	u32 version;
>  
>  	ptable = smem->regions[0].virt_base + smem->regions[0].size - SZ_4K;
>  	if (memcmp(ptable->magic, SMEM_PTABLE_MAGIC, sizeof(ptable->magic)))
> -		return 0;
> +		return NULL;
>  
>  	version = le32_to_cpu(ptable->version);
>  	if (version != 1) {
>  		dev_err(smem->dev,
>  			"Unsupported partition header version %d\n", version);
> +		return ERR_PTR(-EINVAL);

In the calling places NULL and -EINVAL are both treated as -EINVAL, so I
think it's better to just return NULL here as well as check for !ptable
in callers.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/5] soc: qcom: smem: Support global partition Chris Lew <clew@codeaurora.org> - 2017-09-14 23:30 +0200
  Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-15 20:40 +0200
    Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition Chris Lew <clew@codeaurora.org> - 2017-09-15 23:10 +0200

csiph-web