Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1732093

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session
Date 2017-09-14 10:00 +0200
Message-ID <upxe2-2cp-17@gated-at.bofh.it> (permalink)
References <u2P0m-7Rn-11@gated-at.bofh.it> <u2P0m-7Rn-23@gated-at.bofh.it> <uppTc-5UG-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote:
> On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote:
> > iscsi_session_teardown was the only user of this function. Function
> > currently is just short for iscsi_remove_session + iscsi_free_session.
> > 
> > Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
> 
> Why is this needed? I dislike changes that don't fix anything.

The function has no more users left after patch 1, so why keep it bitrotting?

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session Lee Duncan <lduncan@suse.com> - 2017-09-14 02:10 +0200
  Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session Johannes Thumshirn <jthumshirn@suse.de> - 2017-09-14 10:00 +0200

csiph-web