Groups > linux.kernel > #1732083

Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

From	romain izard <romain.izard@mobile-devices.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks
Date	2017-09-14 09:50 +0200
Message-ID	<upx4n-293-7@gated-at.bofh.it> (permalink)
References	<untxU-tS-5@gated-at.bofh.it> <untxV-tS-25@gated-at.bofh.it> <upeXM-7iZ-5@gated-at.bofh.it> <upjkK-1Jw-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-09-13 19:03 GMT+02:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:
>> On 08/09/2017 at 17:35, Romain Izard wrote:
>> > From: Romain Izard <romain.izard@mobile-devices.fr>
>> >
>> > Save and restore the System Clock and Programmable Clock register for
>> > the backup use case.
>>
>> "System Clock" seems to be handled in another patch.
>>
>> > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> > ---
>> >  drivers/clk/at91/pmc.c | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
>> > index 07dc2861ad3f..5421b03553ec 100644
>> > --- a/drivers/clk/at91/pmc.c
>> > +++ b/drivers/clk/at91/pmc.c
>> > @@ -66,6 +66,7 @@ static struct
>> >     u32 pcr[PMC_MAX_IDS];
>> >     u32 audio_pll0;
>> >     u32 audio_pll1;
>> > +   u32 pckr[3];
>>
>> Some products have different numbers of PCK (only 2 on at91sam9x5 for
>> instance)...
>>
>
> My opinion is that it will be time to change that when multiple SoCs will
> need to save their registers.
>
For the next version, I'll add a #define. But as this code requires a
device tree node with the compatible string "atmel,sama5d2-pmc", I believe
that we can ignore other chips for now.


-- 
Romain Izard

Thread

Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable  clocks Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-13 14:30 +0200
  Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable  clocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-09-13 19:10 +0200
    Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks romain izard <romain.izard@mobile-devices.fr> - 2017-09-14 09:50 +0200
      Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable  clocks Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-14 11:40 +0200

csiph-web