Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732042

[PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

Show all headers | View raw

From: zijun_hu <zijun_hu@htc.com>

get_cpu_number() doesn't use existing helper to iterate over possible
CPUs, so error happens in case of discontinuous @cpu_possible_mask
such as 0b11110001.

fixed by using existing helper for_each_possible_cpu().

Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
 drivers/irqchip/irq-gic-v3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 19d642eae096..2a0427c2971e 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -990,7 +990,7 @@ static int get_cpu_number(struct device_node *dn)
 {
 	const __be32 *cell;
 	u64 hwid;
-	int i;
+	int cpu;
 
 	cell = of_get_property(dn, "reg", NULL);
 	if (!cell)
@@ -1004,9 +1004,9 @@ static int get_cpu_number(struct device_node *dn)
 	if (hwid & ~MPIDR_HWID_BITMASK)
 		return -1;
 
-	for (i = 0; i < num_possible_cpus(); i++)
-		if (cpu_logical_map(i) == hwid)
-			return i;
+	for_each_possible_cpu(cpu)
+		if (cpu_logical_map(cpu) == hwid)
+			return cpu;
 
 	return -1;
 }
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by  for_each_possible_cpu() zijun_hu <zijun_hu@zoho.com> - 2017-09-14 07:20 +0200
  Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu() Marc Zyngier <marc.zyngier@arm.com> - 2017-09-14 21:30 +0200
    Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by  for_each_possible_cpu() zijun_hu <zijun_hu@zoho.com> - 2017-09-15 05:10 +0200
      Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu() Marc Zyngier <marc.zyngier@arm.com> - 2017-09-15 16:50 +0200

csiph-web