Groups > linux.kernel > #1731999

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

From	Hoegeun Kwon <hoegeun.kwon@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits
Date	2017-09-14 03:00 +0200
Message-ID	<upqFA-6cM-5@gated-at.bofh.it> (permalink)
References	<upel3-6QI-1@gated-at.bofh.it> <upel4-6QI-19@gated-at.bofh.it> <upel4-6QI-17@gated-at.bofh.it> <upeO5-7fC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/13/2017 09:13 PM, Sylwester Nawrocki wrote:
> On 09/13/2017 01:41 PM, Hoegeun Kwon wrote:
>> @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, 
>> void *priv)
>>       .num_clocks = 1,
>>   };
>>   +static struct gsc_driverdata gsc_v_5250_drvdata = {
>> +    .variant = {
>> +        [0] = &gsc_v_5250_variant,
>> +        [1] = &gsc_v_5250_variant,
>> +        [2] = &gsc_v_5250_variant,
>> +        [3] = &gsc_v_5250_variant,
>> +    },
>> +    .num_entities = 4,
>> +    .clk_names = { "gscl" },
>> +    .num_clocks = 1,
>> +};
>> +
>> +static struct gsc_driverdata gsc_v_5420_drvdata = {
>> +    .variant = {
>> +        [0] = &gsc_v_5420_variant,
>> +        [1] = &gsc_v_5420_variant,
>> +    },
>> +    .num_entities = 4,
>
> Shouldn't num_enities be 2 here? You don't need to resend, I can
> amend that when applying.
>


Yes, num_enities is 2.
Sorry I made a mistake.

Thanks Sylwester.

Best regards,
Hoegeun

>> +    .clk_names = { "gscl" },
>> +    .num_clocks = 1,
>> +};
>> +
>
> -- 
> Regards,
> Sylwester
>
>

Thread

[PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 13:50 +0200
  [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 13:50 +0200
    Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-09-13 14:20 +0200
      Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-14 03:00 +0200
  [PATCH v4 2/4] ARM: dts: exynos: Add clean name of compatible. Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 13:50 +0200
    Re: [PATCH v4 2/4] ARM: dts: exynos: Add clean name of compatible. Krzysztof Kozlowski <krzk@kernel.org> - 2017-09-19 19:40 +0200
  [PATCH v4 1/4] [media] exynos-gsc: Add compatible for Exynos 5250  and 5420 specific version Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 13:50 +0200
  [PATCH v4 3/4] drm/exynos/gsc: Add hardware rotation limits Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-09-13 13:50 +0200
  Re: [PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-09-13 14:30 +0200

csiph-web