Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

From	Josef Bacik <jbacik@fb.com>
Newsgroups	linux.kernel
Subject	Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression
Date	2017-09-13 22:20 +0200
Message-ID	<upmiB-3zs-9@gated-at.bofh.it> (permalink)
References	<up20x-7jY-3@gated-at.bofh.it> <up2Df-7P4-1@gated-at.bofh.it> <upi5j-Mv-3@gated-at.bofh.it> <upmiB-3zs-11@gated-at.bofh.it> <uplPz-3aF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Sep 13, 2017, at 12:46 PM, Chuck Ebbert <cebbert.lkml@gmail.com> wrote:
> 
> On Wed, 13 Sep 2017 17:28:25 +0000
> Josef Bacik <jbacik@fb.com> wrote:
> 
>> Sorry I thought I had made this other fix, can you apply this on top
>> of the other one and try that?  I have more things to try if this
>> doesn’t work, sorry you are playing go between, but I want to make
>> sure I know _which_ fix actually fixes the problem, and then clean up
>> in followup patches.  Thanks,
>> 
>> Josef
>> 
>> On 9/13/17, 8:45 AM, "Laura Abbott" <labbott@redhat.com> wrote:
>> 
>> On 09/12/2017 04:12 PM, Josef Bacik wrote:
>>> First I’m super sorry for the top post, I’m at plumbers and I
>>> forgot to upload my muttrc to my new cloud instance, so I’m screwed
>>> using outlook.
>>> 
>>> I have a completely untested, uncompiled patch that I think will
>>> fix the problem, would you mind giving it a go?  Thanks,
>>> 
>>> Josef  
>> 
>> Thanks for the quick turnaround. Unfortunately, the problem is still
>> reproducible according to the reporter.
>> 
>> Thanks,
>> Laura
> 
> I am confused by the patch that originally caused this:
> 
>        if (sk->sk_family == AF_INET6)
>                return ipv6_rcv_saddr_equal(&sk->sk_v6_rcv_saddr,
> -                                           &sk2->sk_v6_rcv_saddr,
> +                                           inet6_rcv_saddr(sk2),
>                                            sk->sk_rcv_saddr,
>                                            sk2->sk_rcv_saddr,
> 
> Shouldn't the first argument also be changed to use inet6_rcv_saddr()?

No we know sk is IPv6 so it's alright to use directly.  Thanks,

Josef

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind  port regression Laura Abbott <labbott@redhat.com> - 2017-09-13 00:40 +0200
  Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Josef Bacik <jbacik@fb.com> - 2017-09-13 01:20 +0200
    Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Laura Abbott <labbott@redhat.com> - 2017-09-13 17:50 +0200
      Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Josef Bacik <jbacik@fb.com> - 2017-09-13 19:30 +0200
        Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Cole Robinson <crobinso@redhat.com> - 2017-09-13 19:50 +0200
          Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Cole Robinson <crobinso@redhat.com> - 2017-09-13 21:20 +0200
            Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Josef Bacik <jbacik@fb.com> - 2017-09-13 21:50 +0200
              Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Cole Robinson <crobinso@redhat.com> - 2017-09-14 00:50 +0200
                Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Josef Bacik <jbacik@fb.com> - 2017-09-15 20:00 +0200
                Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Cole Robinson <crobinso@redhat.com> - 2017-09-17 15:20 +0200
                Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Marc Haber <mh+linux-kernel@zugschlus.de> - 2017-09-18 10:30 +0200
        Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly")  causes bind port regression Chuck Ebbert <cebbert.lkml@gmail.com> - 2017-09-13 21:50 +0200
          Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes  bind port regression Josef Bacik <jbacik@fb.com> - 2017-09-13 22:20 +0200

csiph-web