Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.

From	Peter Huewe <peterhuewe@gmx.de>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.
Date	2017-09-13 21:10 +0200
Message-ID	<uplcR-2VZ-1@gated-at.bofh.it> (permalink)
References	<umI5X-1TZ-3@gated-at.bofh.it> <umI5X-1TZ-1@gated-at.bofh.it> <umLdw-4da-5@gated-at.bofh.it> <upl3b-2DF-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


Am 13. September 2017 11:52:12 GMT-07:00 schrieb Ken Goldman <kgold@linux.vnet.ibm.com>:
>On 9/6/2017 12:12 PM, Jason Gunthorpe wrote:
>> 
>> The problem with this approach is that the TPM could totally block
>> the CPU for very long periods of time.
>> 
>> It seems very risky to enable..
>> 
>
>How would you characterize "very long"?
>
>The TPM vendors confirm that they empty the FIFO at internal speeds
>that
>are comparable to the bus speed.  Thus, any stall will be sub-usec.  Is
>that an issue?

If the tpm does behave correctly, this is fine. 
If the tpm hangs for whatever reason, your machine is frozen and you will never figure out why.

That's my concern there.
However ddwg seems fine.

>
>In addition, new TPMs have ever larger FIFO's, making stalls less
>likely
>going forward.
But also reduced the polling loops that introduce the performance penalty ;)

>
>
>------------------------------------------------------------------------------
>Check out the vibrant tech community on one of the world's most
>engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>_______________________________________________
>tpmdd-devel mailing list
>tpmdd-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

-- 
Sent from my mobile

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve  tpm_tis send() performance. Ken Goldman <kgold@linux.vnet.ibm.com> - 2017-09-13 21:00 +0200
  Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance. Peter Huewe <peterhuewe@gmx.de> - 2017-09-13 21:10 +0200

csiph-web