Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731782

Re: [PATCH 0/3] perf script: Add script per-event-dump support

Show all headers | View raw

On Mittwoch, 13. September 2017 17:10:30 CEST yuzhoujian wrote:
> Introduce a new option to print trace output to files named by the
> monitored events and update perf-script documentation accordingly.
> 
> Shown below is output of perf script command with the newly introduced
> option.
> 
>         $perf record -e cycles -e context-switches -ag -- sleep 10
>         $perf script --per-event-dump
>         $ls /
>         cycles.stacks context-switches.stacks
> 
> Without per-event-dump support, drawing flamegraphs for different events
> is really hard. You can only monitor one event at a time for perf record.
> Using this option, we can get the trace output files named by the monitored
> events, and could draw flamegraphs according to the event's name.

Not going to argue for or against this patch, but I think the reasoning you 
give in your commit message is outdated:

https://github.com/brendangregg/FlameGraph/commit/
4b7b3169ed303d33fb710e1b9de235b84cc119d3

I.e. with a recent FlameGraph, you can generate flame graphs for different 
events just fine, without any intermediate step.

Cheers

-- 
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] perf script: Add script per-event-dump support yuzhoujian <ufo19890607@gmail.com> - 2017-09-13 17:20 +0200
  [PATCH 1/3] Add a new element for the struct perf_tool, and add the  --per-event-dump option for perf script yuzhoujian <ufo19890607@gmail.com> - 2017-09-13 17:20 +0200
    Re: [PATCH 1/3] Add a new element for the struct perf_tool, and add  the --per-event-dump option for perf script David Ahern <dsahern@gmail.com> - 2017-09-16 17:20 +0200
  [PATCH 2/3] Makes all those related functions receive the FILE pointer yuzhoujian <ufo19890607@gmail.com> - 2017-09-13 17:20 +0200
    Re: [PATCH 2/3] Makes all those related functions receive the FILE  pointer David Ahern <dsahern@gmail.com> - 2017-09-16 17:30 +0200
  [PATCH 3/3] Replace printf with fprintf for all the output functions yuzhoujian <ufo19890607@gmail.com> - 2017-09-13 17:20 +0200
  Re: [PATCH 0/3] perf script: Add script per-event-dump support Milian Wolff <milian.wolff@kdab.com> - 2017-09-13 21:00 +0200

csiph-web