Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC
Date	2017-09-13 19:50 +0200
Message-ID	<upjXr-1Yv-9@gated-at.bofh.it> (permalink)
References	<unKyJ-3Do-1@gated-at.bofh.it> <uoWRd-43L-25@gated-at.bofh.it> <uoYzE-4ZA-9@gated-at.bofh.it> <upjuq-1Ow-13@gated-at.bofh.it> <upjE6-1RR-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/13, Jürg Billeter wrote:
>
> On Wed, 2017-09-13 at 19:11 +0200, Oleg Nesterov wrote:
> > On 09/12, Jürg Billeter wrote:
> > >
> > > On Tue, 2017-09-12 at 19:05 +0200, Oleg Nesterov wrote:
> > > > On 09/09, Jürg Billeter wrote:
> > > > > Unlike
> > > > > PR_SET_PDEATHSIG, this is inherited across fork to allow killing a whole
> > > > > subtree without race conditions.
> > > >
> > > > but I am still not sure this is right... at least I can't understand the
> > > > "without race conditions" above.
> > > >
> > > > IOW, the child can do prctl(PR_SET_PDEATHSIG_PROC, SIGKILL) right after fork(),
> > > > why this is not enough to kill a whole subtree without race conditions?
> > >
> > > What if the parent dies between fork() and prctl()?
> >
> > The child will be killed? Sorry, can't understand...
>
> If PR_SET_PDEATHSIG_PROC was not inherited across fork and the parent
> died between fork() and prctl(PR_SET_PDEATHSIG_PROC, SIGKILL) in the
> child, the child would not be killed.

Aah, sorry. I forgot about another oddity of pdeath_signal API...

Somehow I misread this patch as if reparent_leader() looks at
current->signal->pdeath_signal_proc, not child->signal->pdeath_signal_proc.
And to me the former makes more sense. But I won't insist.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Oleg Nesterov <oleg@redhat.com> - 2017-09-12 19:10 +0200
  Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Jürg Billeter <j@bitron.ch> - 2017-09-12 21:00 +0200
    Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Oleg Nesterov <oleg@redhat.com> - 2017-09-13 19:20 +0200
      Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Jürg Billeter <j@bitron.ch> - 2017-09-13 19:30 +0200
        Re: [PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC Oleg Nesterov <oleg@redhat.com> - 2017-09-13 19:50 +0200

csiph-web