Re: [RFC Part2 PATCH v3 13/26] KVM: SVM: Add KVM_SEV_INIT command

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [RFC Part2 PATCH v3 13/26] KVM: SVM: Add KVM_SEV_INIT command
Date	2017-09-13 18:40 +0200
Message-ID	<upiRI-1k2-19@gated-at.bofh.it> (permalink)
References	<u73o5-oR-3@gated-at.bofh.it> <uphsD-wM-49@gated-at.bofh.it> <uphsD-wM-47@gated-at.bofh.it> <upiRI-1k2-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 13, 2017 at 11:23:26AM -0500, Brijesh Singh wrote:
> I am okay with moving it on the stack but just to give context why
> I went in this way. The physical address of data is given to the
> device (in this case SEV FW). I was not sure if its okay to pass the
> stack address to the device.

Why would it not be ok?

> Additionally, the FW spec requires us to zero all the fields -- so we
> need to memset if we allocate it on the stack.

What do you think kzalloc() does internally? :)

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC Part2 PATCH v3 13/26] KVM: SVM: Add KVM_SEV_INIT command Borislav Petkov <bp@suse.de> - 2017-09-13 17:10 +0200
  Re: [RFC Part2 PATCH v3 13/26] KVM: SVM: Add KVM_SEV_INIT command Borislav Petkov <bp@suse.de> - 2017-09-13 18:40 +0200

csiph-web