Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731658
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andrey Konovalov <andreyknvl@google.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] uwb: properly check kthread_run return value |
| Date | Wed, 13 Sep 2017 17:10:03 +0200 |
| Message-ID | <uphsD-wM-29@gated-at.bofh.it> (permalink) |
| X-Original-To | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Johan Hovold <johan@kernel.org>, "Gustavo A . R . Silva" <garsilva@embeddedor.com>, Arvind Yadav <arvind.yadav.cs@gmail.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ViKLNc87ffYyrfot6DpsIAPYuRZSOkIj3n3rHArKLG4=; b=tjGry7pfg4wBJiUN6X67ayt7LKKmInp4MsA65kJ+wvWwAePhjZThZU7MgViWD2SAHP Q6KFJHogYkjlX0OfWI0enMXm7Wx9qF5Nr6vLs3DZ4bCw2S72BDU70YrvY6Xh2Zr6h5W8 LD6FKsI8Y44YBDDvVAB1IJ7goRtu5MdtbxzXmbReqfBrbIQTF7Gp5a47OsApkYudsOSI R09Fo9i5N+CSdefD42CFeNke75znK3L6kh9xEw76SdObJ2hKJ8h5/2lMHsbDL9x5V/g4 9iyzkQtpgxGmk02F4D9K65x/jxNnPmO+hLzLfR+nvmzvAfMBM5Lj6qEYy/SLAUKAON9k JEeg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ViKLNc87ffYyrfot6DpsIAPYuRZSOkIj3n3rHArKLG4=; b=lTkELOsDrjb2C1Y8Hl3mgjqG7EBOBQJhV0R5akbslk+z8zQQNEg+nQ+AWfKbM17itd nCQENmrdY5ULTa0ucO0uTCdiU7s74u1z0ifUYiEgYZmnjjPo2g0xAmfLPCnE9XbZCi7I rsLxvksphKY8aoLgA6lNe82f12mDQx5TlrvwuI0E4StrmFuKyoGYFYplhiV4u13NOygx zXvEjXLKo5ZwU3obrag6e2ewM25vMMixoZx9CvPpLSoRrJ24Y56pYNd7YVRNqpTBETHb Gg//odwTqH5ofj9tOWFj3Q7G5jq20orjp9fHdJSi0gnPfzSSSiefRCtq/41izMVgMQvQ 6k7Q== |
| X-Gm-Message-State | AHPjjUgdlsm/X21aguFHFTGqBE4nMm8yY5nucniVlXmdhBK0ra6LC0i2 48j5qiFn3Ni7F7me |
| X-Google-SMTP-Source | AOwi7QBe8Dc3pwpNa+f8rvwaiVM13A5qN/jrl82jamBUpsZ8+1FR1aDeVS0f2i5RkTfoD0t9VKkfhA== |
| X-Received | by 10.28.210.204 with SMTP id j195mr2765104wmg.124.1505315217632; Wed, 13 Sep 2017 08:06:57 -0700 (PDT) |
| X-Mailer | git-send-email 2.14.1.581.gf28d330327-goog |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Dmitry Vyukov <dvyukov@google.com>, Kostya Serebryany <kcc@google.com>, Andrey Konovalov <andreyknvl@google.com> |
| X-Original-Date | Wed, 13 Sep 2017 17:06:50 +0200 |
| X-Original-Message-ID | <eaad1afda975d3dac217de3d9a5e5ca83da74f48.1505315045.git.andreyknvl@google.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1731658 |
Show key headers only | View raw
uwbd_start() calls kthread_run() and checks that the return value is
not NULL. But the return value is not NULL in case kthread_run() fails,
it takes the form of ERR_PTR(-EINTR).
Use IS_ERR() instead.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
drivers/uwb/uwbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/uwb/uwbd.c b/drivers/uwb/uwbd.c
index 01c20a260a8b..9f615b303576 100644
--- a/drivers/uwb/uwbd.c
+++ b/drivers/uwb/uwbd.c
@@ -303,7 +303,7 @@ static int uwbd(void *param)
void uwbd_start(struct uwb_rc *rc)
{
rc->uwbd.task = kthread_run(uwbd, rc, "uwbd");
- if (rc->uwbd.task == NULL)
+ if (IS_ERR(rc->uwbd.task))
printk(KERN_ERR "UWB: Cannot start management daemon; "
"UWB won't work\n");
else
--
2.14.1.581.gf28d330327-goog
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] uwb: properly check kthread_run return value Andrey Konovalov <andreyknvl@google.com> - 2017-09-13 17:10 +0200 Re: [PATCH] uwb: properly check kthread_run return value Andrey Konovalov <andreyknvl@google.com> - 2017-09-13 18:10 +0200
csiph-web