Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731674
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic |
| Date | 2017-09-13 17:30 +0200 |
| Message-ID | <uphLX-DH-3@gated-at.bofh.it> (permalink) |
| References | <uomE1-4Gu-1@gated-at.bofh.it> <uomE2-4Gu-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Em Sun, Sep 10, 2017 at 07:23:20PM -0700, kan.liang@intel.com escreveu:
> From: Kan Liang <kan.liang@intel.com>
>
> In case there are two or more threads want to change it.
Please describe the scenario that made you want to have this in place,
to help in reviewing and to have it documented in this patch commit log.
- Arnaldo
> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
> tools/perf/util/machine.c | 11 ++++++-----
> tools/perf/util/machine.h | 2 +-
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index 2f1ad29..bbfb9e0 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -64,8 +64,8 @@ int machine__init(struct machine *machine, const char *root_dir, pid_t pid)
>
> machine->id_hdr_size = 0;
> machine->kptr_restrict_warned = false;
> - machine->comm_exec = false;
> machine->kernel_start = 0;
> + atomic_set(&machine->comm_exec, 0);
>
> memset(machine->vmlinux_maps, 0, sizeof(machine->vmlinux_maps));
>
> @@ -238,14 +238,15 @@ struct machine *machines__add(struct machines *machines, pid_t pid,
>
> void machines__set_comm_exec(struct machines *machines, bool comm_exec)
> {
> + int exec = comm_exec ? 1 : 0;
> struct rb_node *nd;
>
> - machines->host.comm_exec = comm_exec;
> + atomic_set(&machines->host.comm_exec, exec);
>
> for (nd = rb_first(&machines->guests); nd; nd = rb_next(nd)) {
> struct machine *machine = rb_entry(nd, struct machine, rb_node);
>
> - machine->comm_exec = comm_exec;
> + atomic_set(&machine->comm_exec, exec);
> }
> }
>
> @@ -505,7 +506,7 @@ struct thread *machine__find_thread(struct machine *machine, pid_t pid,
> struct comm *machine__thread_exec_comm(struct machine *machine,
> struct thread *thread)
> {
> - if (machine->comm_exec)
> + if (atomic_read(&machine->comm_exec))
> return thread__exec_comm(thread);
> else
> return thread__comm(thread);
> @@ -521,7 +522,7 @@ int machine__process_comm_event(struct machine *machine, union perf_event *event
> int err = 0;
>
> if (exec)
> - machine->comm_exec = true;
> + atomic_set(&machine->comm_exec, 1);
>
> if (dump_trace)
> perf_event__fprintf_comm(event, stdout);
> diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
> index 64663eb..fb3c2a2 100644
> --- a/tools/perf/util/machine.h
> +++ b/tools/perf/util/machine.h
> @@ -38,7 +38,7 @@ struct machine {
> struct rb_node rb_node;
> pid_t pid;
> u16 id_hdr_size;
> - bool comm_exec;
> + atomic_t comm_exec;
> bool kptr_restrict_warned;
> char *root_dir;
> struct threads threads[THREADS__TABLE_SIZE];
> --
> 2.5.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RFC V2 00/10] perf top optimization kan.liang@intel.com - 2017-09-11 04:30 +0200
[PATCH RFC V2 10/10] perf top: switch back to overwrite mode kan.liang@intel.com - 2017-09-11 04:30 +0200
[PATCH RFC V2 04/10] petf tools: introduce a new function to set namespaces id kan.liang@intel.com - 2017-09-11 04:30 +0200
[PATCH RFC V2 06/10] perf tools: lock to protect comm_str rb tree kan.liang@intel.com - 2017-09-11 04:30 +0200
[PATCH RFC V2 02/10] perf tools: using scandir to replace readdir kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 02/10] perf tools: using scandir to replace readdir Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 17:30 +0200
[PATCH RFC V2 03/10] petf tools: using comm_str to replace comm in hist_entry kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 03/10] petf tools: using comm_str to replace comm in hist_entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 17:30 +0200
Re: [PATCH RFC V2 03/10] petf tools: using comm_str to replace comm in hist_entry Jiri Olsa <jolsa@redhat.com> - 2017-09-18 10:40 +0200
[PATCH RFC V2 01/10] perf tools: hashtable for machine threads kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 01/10] perf tools: hashtable for machine threads Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 15:30 +0200
[tip:perf/core] perf machine: Use hashtable for machine threads tip-bot for Kan Liang <tipbot@zytor.com> - 2017-09-22 18:50 +0200
[PATCH RFC V2 08/10] perf top: implement multithreading for perf_event__synthesize_threads kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 08/10] perf top: implement multithreading for perf_event__synthesize_threads Jiri Olsa <jolsa@redhat.com> - 2017-09-18 13:30 +0200
[PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 17:30 +0200
RE: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic "Liang, Kan" <kan.liang@intel.com> - 2017-09-15 22:10 +0200
Re: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic Jiri Olsa <jolsa@redhat.com> - 2017-09-18 13:40 +0200
[PATCH RFC V2 05/10] perf tools: lock to protect thread list kan.liang@intel.com - 2017-09-11 04:30 +0200
Re: [PATCH RFC V2 05/10] perf tools: lock to protect thread list Jiri Olsa <jolsa@redhat.com> - 2017-09-18 11:00 +0200
RE: [PATCH RFC V2 05/10] perf tools: lock to protect thread list "Liang, Kan" <kan.liang@intel.com> - 2017-09-18 18:20 +0200
[PATCH RFC V2 09/10] perf top: add option to set the number of thread for event synthesize kan.liang@intel.com - 2017-09-11 04:30 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-13 17:30 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 17:40 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-14 23:20 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-15 17:20 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-15 19:30 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-15 19:30 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-15 20:30 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-15 20:30 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-13 17:30 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Jiri Olsa <jolsa@redhat.com> - 2017-09-18 11:00 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-18 15:10 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-18 18:30 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Jiri Olsa <jolsa@redhat.com> - 2017-09-19 10:20 +0200
RE: [PATCH RFC V2 00/10] perf top optimization "Liang, Kan" <kan.liang@intel.com> - 2017-09-19 14:50 +0200
Re: [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-19 16:30 +0200
csiph-web