Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
Date	2017-09-13 17:20 +0200
Message-ID	<uphCi-Ah-21@gated-at.bofh.it> (permalink)
References	(2 earlier) <ukV7k-6hA-13@gated-at.bofh.it> <uoWet-3Az-17@gated-at.bofh.it> <up8yZ-3aB-3@gated-at.bofh.it> <upgGe-8st-9@gated-at.bofh.it> <uph9f-aN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 13, 2017 at 04:42:33PM +0200, Florian Eckert wrote:
> >>>
> >>>>> +
> >>>>> +Requires node properties:
> >>>>> +- compatible value :
> >>>>> +	"lantiq,cputemp"
> >>>
> >>>Kind of non-specific. How is this device even accessed without any other
> >>>property?
> >>
> >>It does not need any further properties. If this is set in the device
> >>tree
> >>then the driver is loaded.
> >>After loading the temperature could be read from "/sys/class/hwmon".
> >>Let me know what should i do to get this fixed?
> >>
> 
> What about with this is this OK from your side or do I have do to something?
> So I only update "s/temperatur/temperature/" with an follow-up patch based
> the current linux-next tree?
> 

Also s/cputemp@0/cputemp/ if I understand Rob's comment correctly.

Question for Rob: The driver checks the SOC version and bails out
if the version is not vr9 v1.2. Should that be expressed in DT ?

Guenter

> Thanks
> 
> Florian
> 
>

Thread

Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Rob Herring <robh@kernel.org> - 2017-09-12 18:30 +0200
  Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Florian Eckert <fe@dev.tdt.de> - 2017-09-13 07:40 +0200
    Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Guenter Roeck <linux@roeck-us.net> - 2017-09-13 16:20 +0200
      Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Florian Eckert <fe@dev.tdt.de> - 2017-09-13 16:50 +0200
        Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Guenter Roeck <linux@roeck-us.net> - 2017-09-13 17:20 +0200
    Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Rob Herring <robh@kernel.org> - 2017-09-13 17:30 +0200
      Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Florian Eckert <fe@dev.tdt.de> - 2017-09-14 09:10 +0200
        Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Rob Herring <robh@kernel.org> - 2017-09-20 05:00 +0200
  Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings  documentation Guenter Roeck <linux@roeck-us.net> - 2017-09-13 16:20 +0200

csiph-web