Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1731449

Re: sysbench throughput degradation in 4.13+

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From 王金浦 <jinpuwang@gmail.com>
Newsgroups linux.kernel
Subject Re: sysbench throughput degradation in 4.13+
Date Wed, 13 Sep 2017 10:30:02 +0200
Message-ID <upbdw-4Um-5@gated-at.bofh.it> (permalink)
References <uoUcF-2jr-3@gated-at.bofh.it>
X-Original-To Eric Farman <farman@linux.vnet.ibm.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OnOc2Nosma5/G3plwSwOUHE0swvksloMj7hLndy6s2o=; b=bGjj6xcVyVVefkQ6VWkEOnpA1OGi48LKIr11kT2v+oOob+LUiqglfUHpfT7l5wi0Bk 72+4GL/QTwcbgBAGT83MzWOdaPhdOzgUcPa3yy9byuMaa5fmwKjpjAIlw8puKPo98OQD MD+1CUBZekmjLmj+C3C1iqI/6dChl6D6Mr2eF9lz5Y2uH9zo6ckdWFN1sQJpCBj4FG0H r86TG1mgaJr98nyWiJblKtREYk0ryj8NHfDUbfvcsc5f/h9YNwxYqYVZHb4HD13nIBML Az4Ebu19NEFAXyr+qX+yKmD9uNrOg63YcjO7IrTrEeiWVwv5j4SHFy9GtYcVOudmkmaS ctuA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OnOc2Nosma5/G3plwSwOUHE0swvksloMj7hLndy6s2o=; b=HLMin1VjvgKfpABkJvN5G9N1t3C1gVd9FAzw1/ek06JaSu+s8rfYO3XQQt0fuKvYvO Ys4aQ9N6r8Y0kqiNFrrZ5lhAWD/tuCgavgH6m2xO2n41m460dD5VBMOHhzhukWlhqvaa 3VIAbwpgtFRnKt5GeQlv1PPvVGKKwQRiiwpAEXg5y0sIRZLruchRld6/ToXhL1GBt91x 90IkOa7RC76oXRD0BIgXkwGu4IiFzmZuXqAKOe9fzYVhSAn+GXNkZQ6pZN9ql/Nh4iaY Nsk8aexYV2OE7z5XLfZA/Z7Ycav8iULa2rIwyeEzxDZ+l9WNewBy1D1ZSakn3kw8JQrM 5n1g==
X-Gm-Message-State AHPjjUjHeZT+SFAe/zoJdW9VmfYNZTIVi28yNx0oQ/I592rKdDL4wLk3 6Td7T5tm/GGIdcQEUpCNQmYWiNGG3TmnhpVMYRQ=
X-Google-SMTP-Source AOwi7QAoVh4y9vIR13Arm3cpFphViZQwS2ZjDIjOjyjXWBmLFPIAR4AAxCXtHypmJvJiApR6Cg3XxGyBgbaYLgt3LOc=
X-Received by 10.25.143.199 with SMTP id s68mr5439236lfk.143.1505291068980; Wed, 13 Sep 2017 01:24:28 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 69
Organization linux.* mail to news gateway
X-Original-Cc Peter Zijlstra <peterz@infradead.org>, Rik van Riel <riel@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, "KVM-ML (kvm@vger.kernel.org)" <kvm@vger.kernel.org>, vcaputo@pengaru.com
X-Original-Date Wed, 13 Sep 2017 10:24:28 +0200
X-Original-Message-ID <CAD9gYJJ9nSAbznEn80hfY3=+YjA8cKw6RztpgW6iDm7rQ0EsFg@mail.gmail.com>
X-Original-References <95edafb1-5e9d-8461-db73-bcb002b7ebef@linux.vnet.ibm.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1731449

Show key headers only | View raw


2017-09-12 16:14 GMT+02:00 Eric Farman <farman@linux.vnet.ibm.com>:
> Hi Peter, Rik,
>
> Running sysbench measurements in a 16CPU/30GB KVM guest on a 20CPU/40GB
> s390x host, we noticed a throughput degradation (anywhere between 13% and
> 40%, depending on test) when moving the host from kernel 4.12 to 4.13.  The
> rest of the host and the entire guest remain unchanged; it is only the host
> kernel that changes.  Bisecting the host kernel blames commit 3fed382b46ba
> ("sched/numa: Implement NUMA node level wake_affine()").
>
> Reverting 3fed382b46ba and 815abf5af45f ("sched/fair: Remove
> effective_load()") from a clean 4.13.0 build erases the throughput
> degradation and returns us to what we see in 4.12.0.
>
> A little poking around points us to a fix/improvement to this, commit
> 90001d67be2f ("sched/fair: Fix wake_affine() for !NUMA_BALANCING"), which
> went in the 4.14 merge window and an unmerged fix [1] that corrects a small
> error in that patch.  Hopeful, since we were running !NUMA_BALANCING, I
> applied these two patches to a clean 4.13.0 tree but continue to see the
> performance degradation.  Pulling current master or linux-next shows no
> improvement lurking in the shadows.
>
> Running perf stat on the host during the guest sysbench run shows a
> significant increase in cpu-migrations over the 4.12.0 run.  Abbreviated
> examples follow:
>
> # 4.12.0
> # perf stat -p 11473 -- sleep 5
>       62305.199305      task-clock (msec)         #   12.458 CPUs
>            368,607      context-switches
>              4,084      cpu-migrations
>                416      page-faults
>
> # 4.13.0
> # perf stat -p 11444 -- sleep 5
>       35892.653243      task-clock (msec)         #    7.176 CPUs
>            249,251      context-switches
>             56,850      cpu-migrations
>                804      page-faults
>
> # 4.13.0-revert-3fed382b46ba-and-815abf5af45f
> # perf stat -p 11441 -- sleep 5
>       62321.767146      task-clock (msec)         #   12.459 CPUs
>            387,661      context-switches
>              5,687      cpu-migrations
>              1,652      page-faults
>
> # 4.13.0-apply-90001d67be2f
> # perf stat -p 11438 -- sleep 5
>       48654.988291      task-clock (msec)         #    9.729 CPUs
>            363,150      context-switches
>             43,778      cpu-migrations
>                641      page-faults
>
> I'm not sure what doc to supply here and am unfamiliar with this code or its
> recent changes, but I'd be happy to pull/try whatever is needed to help
> debug things.  Looking forward to hearing what I can do.
>
> Thanks,
> Eric
>
> [1] https://lkml.org/lkml/2017/9/6/196
>
+cc: vcaputo@pengaru.com
He reported a performance degradation also on 4.13-rc7, it might be
the same cause.

Best,
Jack

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

sysbench throughput degradation in 4.13+ Eric Farman <farman@linux.vnet.ibm.com> - 2017-09-12 16:20 +0200
  Re: sysbench throughput degradation in 4.13+ 王金浦 <jinpuwang@gmail.com> - 2017-09-13 10:30 +0200
    Re: sysbench throughput degradation in 4.13+ Eric Farman <farman@linux.vnet.ibm.com> - 2017-09-22 17:10 +0200
      Re: sysbench throughput degradation in 4.13+ Peter Zijlstra <peterz@infradead.org> - 2017-09-22 18:00 +0200
        Re: sysbench throughput degradation in 4.13+ Eric Farman <farman@linux.vnet.ibm.com> - 2017-09-22 18:20 +0200

csiph-web