Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1732902

Re: [experimental PATCH] ovl: get rid of d_real()

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [experimental PATCH] ovl: get rid of d_real()
Date 2017-09-15 16:10 +0200
Message-ID <upZtE-3TS-25@gated-at.bofh.it> (permalink)
References <upZjY-3B1-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Sep 15, 2017 at 03:58:05PM +0200, Miklos Szeredi wrote:
> And here's the prototype.  Poof, d_real() is gone.
> 
> It definitely has got problems, but just maybe it can be made better than the
> current mess.  It *does* solve the ro-rw inconsistency for normal reads (not
> mmaps).

... and makes for mind-boggling amount of opening/closing the files on underlying
filesystem.  Doing that on sodding ->read_iter() is simply wrong.  And you are
using the wrong credentials for those opens, anyway - it should be creds of opener,
not reader.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[experimental PATCH] ovl: get rid of d_real() Miklos Szeredi <miklos@szeredi.hu> - 2017-09-15 16:00 +0200
  Re: [experimental PATCH] ovl: get rid of d_real() Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-15 16:10 +0200
    Re: [experimental PATCH] ovl: get rid of d_real() Miklos Szeredi <miklos@szeredi.hu> - 2017-09-15 19:20 +0200

csiph-web