Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1732900

[PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

From Romain Izard <romain.izard.pro@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors
Date 2017-09-15 16:10 +0200
Message-ID <upZtE-3TS-21@gated-at.bofh.it> (permalink)
References <upZtD-3TS-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


It is not normal for the PMECC to fail when trying to fix ECC errors.
Report these cases as errors.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
 drivers/mtd/nand/atmel/pmecc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index 8d1208f38025..2a23f1ff945f 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)
 	 * Number of roots does not match the degree of smu
 	 * unable to correct error.
 	 */
+	dev_err(pmecc->dev,
+		"PMECC: Impossible to calculate error location.\n");
 	return -EBADMSG;
 }
 
@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,
 			ptr = ecc + byte - sectorsize;
 			area = "ECC";
 		} else {
-			dev_dbg(pmecc->dev,
+			dev_err(pmecc->dev,
 				"Invalid errpos value (%d, max is %d)\n",
 				errpos, (sectorsize + eccbytes) * 8);
 			return -EINVAL;
-- 
2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/9] Various patches for SAMA5D2 backup mode Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
  [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-19 12:20 +0200
    Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend Richard Genoud <richard.genoud@gmail.com> - 2017-09-20 16:40 +0200
  [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-22 14:40 +0200
  [PATCH v2 7/9] pwm: atmel-tcb: Support backup mode Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 7/9] pwm: atmel-tcb: Support backup mode Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-22 14:50 +0200
  [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-09-22 14:10 +0200
    Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-22 14:20 +0200
  [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as  errors Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-18 12:10 +0200
      Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors Romain Izard <romain.izard.pro@gmail.com> - 2017-09-21 11:30 +0200
  [PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving  backup mode Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-18 12:00 +0200
  [PATCH v2 2/9] clk: at91: pmc: Save SCSR during suspend Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
  [PATCH v2 8/9] atmel_flexcom: Support backup mode Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-19 11:30 +0200
      Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode Lee Jones <lee.jones@linaro.org> - 2017-09-19 17:30 +0200
        Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode Romain Izard <romain.izard.pro@gmail.com> - 2017-09-20 10:40 +0200
          Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-09-20 11:20 +0200
  [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks Romain Izard <romain.izard.pro@gmail.com> - 2017-09-15 16:10 +0200
    Re: [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable  clocks Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-09-22 12:40 +0200
      Re: [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks Romain Izard <romain.izard.pro@gmail.com> - 2017-09-25 10:30 +0200

csiph-web