Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1732870

[PATCH bisected regression in 4.14] PCI: fix race while enabling upstream bridges concurrently

Show all headers | View raw

In pci_enable_bridge() pci_enable_device() is called before calling
pci_set_master(), thus check pci_is_enabled() becomes true in the
middle of this sequence. As a result in pci_enable_device_flags()
concurrent enable of device on same bridge could think that this
bridge is completely enabled, but actually it's not yet.

For me this race broke ethernet devices after booting kernel via
kexec, normal reboot was fine.

This patch removes racy fast-path: pci_enable_bridge() will take
pci_bridge_mutex and do nothing if bridge is already enabled.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 40f11adc7cd9 ("PCI: Avoid race while enabling upstream bridges")
---
 drivers/pci/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b0002daa50f3..ffbe11dbdd61 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1394,7 +1394,7 @@ static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags)
 		return 0;		/* already enabled */
 
 	bridge = pci_upstream_bridge(dev);
-	if (bridge && !pci_is_enabled(bridge))
+	if (bridge)
 		pci_enable_bridge(bridge);
 
 	/* only skip sriov related */

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH bisected regression in 4.14] PCI: fix race while enabling  upstream bridges concurrently Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-09-15 14:50 +0200
  Re: [PATCH bisected regression in 4.14] PCI: fix race while enabling  upstream bridges concurrently Srinath Mannam <srinath.mannam@broadcom.com> - 2017-09-15 15:50 +0200
    Re: [PATCH bisected regression in 4.14] PCI: fix race while enabling  upstream bridges concurrently Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-09-16 09:20 +0200

csiph-web